-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP Integration #23
Merged
Merged
MVP Integration #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbosio
force-pushed
the
integration
branch
from
October 2, 2023 20:10
85c5cd6
to
dd1ad52
Compare
gabrielbosio
force-pushed
the
integration
branch
2 times, most recently
from
October 3, 2023 17:30
c250b0a
to
90e45f0
Compare
This reverts commit 90e45f0.
Co-authored-by: Pablo Deymonnaz <[email protected]>
gabrielbosio
force-pushed
the
integration
branch
from
October 4, 2023 16:40
0d1fc23
to
c2c5f88
Compare
pablodeymo
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MVP flow would be:
public_input_gen
to create public inputs for the verifier circuit.evm_bridge
to create the verifier circuit.kzg_prover
to create the circuit proof.NOTE: to merge this, first merge #21 and #20.