Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change macos-12 to macos-13 #1883

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change macos-12 to macos-13 #1883

wants to merge 4 commits into from

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Nov 25, 2024

Change macos-12 to macos-13

Description

Since macos-12 has been deprecated, this PR changes the workflows to use macos-latest.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Nov 25, 2024

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     32.412 s ±  0.039 s    [User: 31.672 s, System: 0.738 s]
  Range (min … max):   32.384 s … 32.440 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     32.331 s ±  0.018 s    [User: 31.550 s, System: 0.780 s]
  Range (min … max):   32.318 s … 32.344 s    2 runs
 
Summary
  'hyper_threading_pr threads: 1' ran
    1.00 ± 0.00 times faster than 'hyper_threading_main threads: 1'




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.915 s ±  0.016 s    [User: 31.359 s, System: 0.786 s]
  Range (min … max):   17.904 s … 17.927 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     17.900 s ±  0.024 s    [User: 31.375 s, System: 0.764 s]
  Range (min … max):   17.884 s … 17.917 s    2 runs
 
Summary
  'hyper_threading_pr threads: 2' ran
    1.00 ± 0.00 times faster than 'hyper_threading_main threads: 2'




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.694 s ±  0.054 s    [User: 43.560 s, System: 0.915 s]
  Range (min … max):   12.655 s … 12.732 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.359 s ±  0.489 s    [User: 43.669 s, System: 0.939 s]
  Range (min … max):   12.013 s … 12.704 s    2 runs
 
Summary
  'hyper_threading_pr threads: 4' ran
    1.03 ± 0.04 times faster than 'hyper_threading_main threads: 4'




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     12.052 s ±  0.301 s    [User: 44.067 s, System: 0.984 s]
  Range (min … max):   11.839 s … 12.265 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     12.109 s ±  0.027 s    [User: 43.649 s, System: 0.998 s]
  Range (min … max):   12.089 s … 12.128 s    2 runs
 
Summary
  'hyper_threading_main threads: 6' ran
    1.00 ± 0.03 times faster than 'hyper_threading_pr threads: 6'




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.841 s ±  0.172 s    [User: 44.214 s, System: 0.958 s]
  Range (min … max):   11.719 s … 11.962 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.943 s ±  0.153 s    [User: 44.372 s, System: 0.995 s]
  Range (min … max):   11.835 s … 12.051 s    2 runs
 
Summary
  'hyper_threading_main threads: 8' ran
    1.01 ± 0.02 times faster than 'hyper_threading_pr threads: 8'




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     11.882 s ±  0.167 s    [User: 44.469 s, System: 1.101 s]
  Range (min … max):   11.764 s … 12.000 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.697 s ±  0.020 s    [User: 44.703 s, System: 1.010 s]
  Range (min … max):   11.683 s … 11.711 s    2 runs
 
Summary
  'hyper_threading_pr threads: 16' ran
    1.02 ± 0.01 times faster than 'hyper_threading_main threads: 16'


Copy link

github-actions bot commented Nov 25, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.519 ± 0.048 2.475 2.606 1.00 ± 0.02
head big_factorial 2.517 ± 0.034 2.479 2.587 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.468 ± 0.054 2.433 2.617 1.00 ± 0.02
head big_fibonacci 2.457 ± 0.021 2.431 2.499 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.260 ± 0.113 9.111 9.519 1.00
head blake2s_integration_benchmark 9.261 ± 0.202 9.039 9.748 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.583 ± 0.010 2.571 2.604 1.00 ± 0.01
head compare_arrays_200000 2.580 ± 0.017 2.558 2.611 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.684 ± 0.021 1.667 1.738 1.00
head dict_integration_benchmark 1.688 ± 0.011 1.667 1.699 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.441 ± 0.046 1.412 1.560 1.01 ± 0.03
head field_arithmetic_get_square_benchmark 1.427 ± 0.006 1.418 1.437 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.311 ± 0.081 9.183 9.427 1.00 ± 0.02
head integration_builtins 9.299 ± 0.142 9.192 9.689 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.723 ± 0.367 9.464 10.689 1.01 ± 0.04
head keccak_integration_benchmark 9.618 ± 0.159 9.470 10.028 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.586 ± 0.021 2.566 2.637 1.00 ± 0.02
head linear_search 2.575 ± 0.032 2.551 2.654 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.749 ± 0.019 1.726 1.784 1.00
head math_cmp_and_pow_integration_benchmark 1.762 ± 0.027 1.728 1.822 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.693 ± 0.016 1.670 1.715 1.00
head math_integration_benchmark 1.707 ± 0.037 1.669 1.805 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.436 ± 0.011 1.415 1.450 1.00
head memory_integration_benchmark 1.442 ± 0.012 1.426 1.456 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.827 ± 0.029 1.805 1.907 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.809 ± 0.014 1.783 1.830 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 591.4 ± 5.7 587.3 607.0 1.00
head pedersen 591.8 ± 10.7 582.6 613.4 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 711.5 ± 11.7 701.0 739.7 1.01 ± 0.02
head poseidon_integration_benchmark 702.8 ± 5.1 693.5 712.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.075 ± 0.016 2.061 2.114 1.00 ± 0.01
head secp_integration_benchmark 2.068 ± 0.019 2.049 2.113 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 686.7 ± 5.4 678.1 698.1 1.00
head set_integration_benchmark 690.3 ± 13.7 683.8 728.9 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.112 ± 0.127 5.019 5.376 1.01 ± 0.03
head uint256_integration_benchmark 5.067 ± 0.048 5.005 5.143 1.00

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (0b30ba2) to head (745b8f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1883   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         102      102           
  Lines       40687    40687           
=======================================
  Hits        39195    39195           
  Misses       1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrancoGiachetta FrancoGiachetta changed the title Change macos-12 to latest Change macos-12 to macos-15 Nov 25, 2024
@FrancoGiachetta FrancoGiachetta changed the title Change macos-12 to macos-15 Change macos-12 to macos-13 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Implementation of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants