Use uuid4 instead of uuid1

Until now the prefix uuid was generated with 'uuid1' command. In cases where you started two environments with the same network names - the uuid1 usage caused us to pass the same network name to libvirt, despite the environments being different, thus throwing a libvirt error. The reason is that we truncated the 8 last bytes of the uuid1 and joined that with the network name. The 8 last bytes of uuid1 are most definitely not random. I see no reason to have the uuid not completely random - therefore this patch changes the prefix uuid to be generated with uuid4, which should be completely random. Signed-off-by: Nadav Goldin <[email protected]>
lago-project · Jul 1, 2017 · ab3919a · ab3919a
1 parent d0959e2
commit ab3919a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lago/prefix.py b/lago/prefix.py
@@ -207,8 +207,8 @@ def initialize(self):
             rollback.prependDefer(shutil.rmtree, prefix)
 
             with open(self.paths.uuid(), 'w') as f, \
-                    LogTask('Generate prefix uuid'):
-                f.write(uuid.uuid1().hex)
+                    LogTask('Generate prefix uuid4'):
+                f.write(uuid.uuid4().hex)
 
             with LogTask('Create ssh keys'):
                 self._create_ssh_keys()

diff --git a/lago/virt.py b/lago/virt.py
@@ -37,7 +37,7 @@
 
 
 def _gen_ssh_command_id():
-    return uuid.uuid1().hex[:8]
+    return uuid.uuid4().hex[:8]
 
 
 def _guestfs_copy_path(g, guest_path, host_path):