Extend the partition of / filesystem #30
Conversation
Signed-off-by: Galit <[email protected]>
galitf
force-pushed
the
extend_partition
branch
from
0612d0e to
94ead10
Compare
| Create a copy of the disk | ||
|
|
||
| Args: | ||
| dst_img = old disk image |
There was a problem hiding this comment.
Can you please use the docstring format we use in lago?
| dst_image, | ||
| new_size | ||
| ] | ||
| print(cmd) |
There was a problem hiding this comment.
Can we use the logger for that?
| ) | ||
|
|
||
|
|
||
| def resize_image_partition(dst_image, new_dst_image, partition="/dev/sda4", fail_on_error=True): |
There was a problem hiding this comment.
I wouldn't put a default value for the partition since it can change between images.
| None | ||
|
|
||
| """ | ||
| cmd = [ |
There was a problem hiding this comment.
You can use os.unlink it will be simpler
| @@ -108,6 +109,114 @@ def virt_builder(base_image, dst_image, commands_file, fail_on_error=True): | |||
| ) | |||
|
|
|||
|
|
|||
| def resize_disk_image(dst_image, new_size, fail_on_error=True): | |||
| """ | |||
| Create a copy of the disk | |||
| new_size=self.spec.size, | ||
| ) | ||
|
|
||
| build_utils.copy_image_with_cp( |
There was a problem hiding this comment.
Why is this needed? the previous step already creates a copy of the original disk.
| partition=self.spec.expand | ||
| ) | ||
|
|
||
| build_utils.remove_disk_image( |
There was a problem hiding this comment.
This should be called inside of a finally, just in case the previous commands were failed.
| dst_image=self.dst_path, | ||
| ) | ||
|
|
||
| build_utils.copy_image_with_cp( |
| @@ -185,6 +215,36 @@ def custom_build_action(self, *args, **kwargs): | |||
| commands_file=self.spec.commands_file | |||
| ) | |||
|
|
|||
| if self.spec.size == 0: | |||
There was a problem hiding this comment.
Shouldn't it be self.spec.size != 0 ?
| @@ -185,6 +215,36 @@ def custom_build_action(self, *args, **kwargs): | |||
| commands_file=self.spec.commands_file | |||
| ) | |||
|
|
|||
| if self.spec.size == 0: | |||
| build_utils.resize_disk_image( | |||
There was a problem hiding this comment.
If this flow is identical to the flow in LibguestFSImage it can be moved to a method in the Image class (or other function that you'll find appropriate).
Signed-off-by: Galit [email protected]