-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVE 7.x support #155
PVE 7.x support #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #143
Also with PVE 7, I think we can sunset support for PVE 5/Debian Stretch since they're EOL (but I don't think this means much code cleanup like we had with PVE 4).
Can you remove all the PVE 5 stuff as well? Otherwise it looks fine to me.
Thanks @trickert76 for making those changes this morning, apologies i have had a very busy month so far. I will finish this PR off this week so that it can be merged. |
a43b723
to
da3af7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LGTM and nice job. If anyone can easily do so currently, can someone test out these final set of changes by doing one of the following?
a) deploy both a Debian Bullseye 3-node cluster and a Debian Buster 3-node cluster on physical hardware with Ceph
b) use vagrant to do the above instead, if anyone already has a vagrant setup using libvirt.
The Vagrantfile would need to be updated to use a bullseye image (probably debian/bullseye64 exists) to test a PVE 7 deployment. Don't think anything else would need to be changed.
I'd do this myself right now if I could but I recently replaced my workstation setup to actually use Proxmox as the host OS and my desktop/development OS is a VM guest on it that doesn't have vagrant/libvirt/networking properly configured to be able to use this role's Vagrantfile yet (but maybe I can try to figure that out soon). Speaking of, would be nice if there was a Vagrant provider for Proxmox that was still maintained... (I couldn't find any last time I looked, which was relatively recently I think)
Okay, I got around to setting up libvirt/vagrant in my new setup. The
Haven't looked into it yet, but seems like a serious issue? Going to attempt a PVE 7 deployment in a bit and see if the same occurs. Also these are the only files that exist at that point in the deployment:
|
PVE 7.x deployment first attempt (took a bit longer because I was hitting disk space issues lol):
Seems like the
Dunno what we should do about this one—I assume most people are configuring Anyway, after manually fixing it for testing, it looks like the Ceph OSD task is still failing for PVE 7, with the same issue:
|
So the change to the
The |
Right ok, i shall revert to the 'pveceph osd create' way of doing it. Thats my fault for only testing that change on an already running PVE with new OSD's. All the keys would have already been there! |
Just confirming that reverting back to the original command task seems to work in finishing up the deployment (i.e. I made the change and re-ran It sounds like you're going to push that change here? If so I'll wait. After that I'm going to attempt to rebase and cleanup the commits into smaller ones and then do a final test and merge if that works. |
97db517
to
5a6a626
Compare
Use smaller block device for Ceph testing.
Merged. Thanks all! |
No description provided.