fix: add more permissions that are needed for resource group v2 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarekbote
approved these changes
May 15, 2024
badass-aoz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To support RG v2, we'll need to query for folder and organization information. That entails the following perms:
This PR adds those two perms. For org-level integration this is trivial, because I can just add those two permissions to the existing perm list. For project-level integration I need to create a separate org-level custom role, because those two permissions only exist at org-level and GCP wouldn't allow you to add those perms to a project-level role.
Happy to hear suggestions on better implementations.
Related PR: https://github.com/lacework-dev/sidekick/pull/1094
How did you test this change?
deployed with both
org-level-multi-regionandproject-level-multi-regionexamples and inspect analyze.ndjson files to verify that tags are generated correctly. Screenshots:Issue
https://lacework.atlassian.net/browse/LINK-2695