Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request for projects.get perm #52

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: request for projects.get perm #52

merged 1 commit into from
Feb 13, 2024

Conversation

badass-aoz
Copy link
Contributor

@badass-aoz badass-aoz commented Feb 12, 2024

Summary

This adds an additional permission in monitored GCP projects. See https://github.com/lacework-dev/sidekick/pull/816 for details.

How did you test this change?

See the aforementioned PR for details.

Issue

https://lacework.atlassian.net/browse/LINK-2609

@badass-aoz badass-aoz requested a review from a team February 12, 2024 21:35
@badass-aoz badass-aoz marked this pull request as ready for review February 12, 2024 23:36
Copy link
Contributor

@maxpyf maxpyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@badass-aoz badass-aoz merged commit 331a3c0 into main Feb 13, 2024
2 checks passed
@badass-aoz badass-aoz deleted the new_perm branch February 13, 2024 18:08
@lacework-releng lacework-releng mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants