feat: Remove RGv1 logic. Add KUBERNETES to ResourceGroups #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lei Jin <[email protected]>
Signed-off-by: Lei Jin <[email protected]>
Signed-off-by: Lei Jin <[email protected]>
Signed-off-by: Lei Jin <[email protected]>
leijin-lw
force-pushed
the
rgv2-cleanup
branch
from
019a65e to
5679383
Compare
zekisherif
requested review from
PengyuanZhao,
dmurray-lacework,
leijin-lw,
lwmobeent and
aneesh-mysore
zekisherif
changed the title
PengyuanZhao
approved these changes
Oct 30, 2024
leijin-lw
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get rid of all RGv1 logic and remove unnecessary wrappers on structs now that we don't have to convert between different object models.
This also adds Kubernetes resource group to the APIs as KSPM team missed updating this.
How did you test this change?
Updated unit- tests, examples, integration-tests
Ran resource-group cli commands succesfully for create, delete and show