Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix tests and remove extra docker login in release.yml #1569

Merged
merged 4 commits into from
Feb 29, 2024
Merged

ci: fix tests and remove extra docker login in release.yml #1569

merged 4 commits into from
Feb 29, 2024

Conversation

PengyuanZhao
Copy link
Contributor

@PengyuanZhao PengyuanZhao commented Feb 28, 2024 •
edited
Loading

Summary

  • There is already docker login in release.sh. Remove the extra step.
  • Fix the LQL query create/update tests
  • Don't send Slack alerts in test-build for PRs.

How did you test this change?

Run test-build

@PengyuanZhao PengyuanZhao changed the title ci: fix dockerhub in release.yml ci: fix tests and remove extra docker login in release.yml Feb 29, 2024
@PengyuanZhao PengyuanZhao marked this pull request as ready for review February 29, 2024 15:15
@PengyuanZhao PengyuanZhao requested a review from a team as a code owner February 29, 2024 15:15
@PengyuanZhao PengyuanZhao merged commit fc6cd42 into main Feb 29, 2024
11 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/GROW-2773-dockerhub branch February 29, 2024 15:18
@lacework-releng lacework-releng mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmac1973 tmac1973 tmac1973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PengyuanZhao @tmac1973