ci: Create workflow test-build.yml #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PengyuanZhao
changed the title
jon-stewart
reviewed
Feb 14, 2024
| needs: [run-tests, trigger-release] | ||
| steps: | ||
| - name: Notify Slack on Failure | ||
| uses: slackapi/[email protected] |
There was a problem hiding this comment.
Release/DXP would prefer that we use https://github.com/lacework-dev/actions/tree/main/report-to-slack-v1
That was the feedback I received in a PR for Github workflow changes
There was a problem hiding this comment.
uh.. is that recommended or mandatory? The lw report-to-slack action can't pick up the @ in the text. And fields are laid out in two columns in a weird order.
tmac1973
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Codefresh go-sdk/test-build to GitHub actions
How did you test this change?
https://github.com/lacework/go-sdk/actions/runs/7908492159/job/21587784031?pr=1534
Issue
https://lacework.atlassian.net/browse/GROW-2758