ci: fix TestContainerVulnerabilityCommandsEndToEnd #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <[email protected]>
kendall-choy-lw
approved these changes
Dec 13, 2023
Just by using the `Returns` field on the search. 🤦
```
➜ go-sdk git:(afiune/ci/fix) date;./bin/lacework-cli-darwin-amd64 vuln container show-assessment sha256:a65572164cb78c4d04f57bd66201c775e2dab08fce394806a03a933c5daf9e48 --image_id --nocache;date
Tue Dec 12 17:26:07 PST 2023
Flag --image_id has been deprecated, by default we now look up both, image_id and image_digest at once.
CONTAINER IMAGE DETAILS VULNERABILITIES
------------------------------------------------------------------------------------------+---------------------------------
ID sha256:a65572164cb78c4d04f57bd66201c775e2dab08fce394806a03a933c5daf9e48 SEVERITY COUNT FIXABLE
Digest sha256:77b2d2246518044ef95e3dbd029e51dd477788e5bf8e278e418685aabc3fe28a -----------+-------+----------
Registry index.docker.io Critical 45 30
Repository techallylw/test-cli-dirty High 169 91
Size 343.9 MB Medium 143 85
Created At 2020-11-12T00:29:45Z Low 0 0
Tags latest Info 345 6
Try adding '--details' to increase details shown about the vulnerability assessment.
Tue Dec 12 17:26:36 PST 2023
➜ go-sdk git:(afiune/ci/fix) ✗ date;lacework vuln container show-assessment sha256:a65572164cb78c4d04f57bd66201c775e2dab08fce394806a03a933c5daf9e48 --image_id --nocache;date
Tue Dec 12 17:26:57 PST 2023
Flag --image_id has been deprecated, by default we now look up both, image_id and image_digest at once.
CONTAINER IMAGE DETAILS VULNERABILITIES
------------------------------------------------------------------------------------------+---------------------------------
ID sha256:a65572164cb78c4d04f57bd66201c775e2dab08fce394806a03a933c5daf9e48 SEVERITY COUNT FIXABLE
Digest sha256:77b2d2246518044ef95e3dbd029e51dd477788e5bf8e278e418685aabc3fe28a -----------+-------+----------
Registry index.docker.io Critical 45 30
Repository techallylw/test-cli-dirty High 169 91
Size 343.9 MB Medium 143 85
Created At 2020-11-12T00:29:45Z Low 0 0
Tags latest Info 345 6
Try adding '--details' to increase details shown about the vulnerability assessment.
Tue Dec 12 17:31:08 PST 2023
➜ go-sdk git:(afiune/ci/fix) ✗
```
Signed-off-by: Salim Afiune Maya <[email protected]>
kendall-choy-lw
approved these changes
Dec 13, 2023
|
integration all |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a feeling that the problem of this test is that we run all the
t.Run()statements in parallel, I think.How did you test this change?
Run integration tests locally. CI should be green.
Issue
N/A