feat(PSP-1220): add new cloud account type for Azure Agentless integration #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japsingh
reviewed
Nov 8, 2023
api/cloud_accounts_azure_sidekick.go
Outdated
| type AzureSidekickData struct { | ||
| Credentials AzureSidekickCredentials `json:"credentials"` | ||
| IntegrationType string `json:"integrationType"` // SUBSCRIPTION or TENANT | ||
| SubscriptionId string `json:"subscriptionId"` |
There was a problem hiding this comment.
This should be named scanningSubscriptionId, isn't it?
https://github.com/lacework/rainbow/blob/7b6b998bb4b8ec14f11fb0700e1cff12fce2bf7f/iris/src/main/resources/schema/INTEGRATION_SCHEMA.json#L312
japsingh
reviewed
Nov 8, 2023
api/cloud_accounts_azure_sidekick.go
Outdated
|
|
||
| type AzureSidekickData struct { | ||
| Credentials AzureSidekickCredentials `json:"credentials"` | ||
| IntegrationType string `json:"integrationType"` // SUBSCRIPTION or TENANT |
There was a problem hiding this comment.
japsingh
reviewed
Nov 8, 2023
api/cloud_accounts_azure_sidekick.go
Outdated
| type AzureSidekickCredentials struct { | ||
| ClientID string `json:"clientId"` | ||
| ClientSecret string `json:"clientSecret,omitempty"` | ||
| CredentialType string `json:"credentialType"` // SharedCredentials or SharedAccess |
There was a problem hiding this comment.
Currently AZURE_SIDEKICK integration schema doesn't have credentialType, so adding it would violate the schema. Is this field necessary? If yes, we would have to add it to the schema.
|
Nice work @qianxuweiren |
|
Exactly the feedbacks I wanted. Thanks Japneet. Fix coming up shortly. |
badass-aoz
changed the title
japsingh
approved these changes
Nov 8, 2023
ammarekbote
approved these changes
Nov 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is needed to support Agentless running on Azure.
How did you test this change?
Added a test.
make testpassed. AlsoIssue
https://lacework.atlassian.net/browse/PSP-1220