feat: Support bucket encryption for existing cloudtrail

Signed-off-by: Lei Jin <[email protected]>
lacework · Sep 5, 2024 · dc95d0a · dc95d0a
1 parent e5ecd21
commit dc95d0a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/cli/cmd/content_library_internal_test.go b/cli/cmd/content_library_internal_test.go
@@ -311,7 +311,7 @@ func TestLoadLCLNotFound(t *testing.T) {
 	_, err := cli.LoadLCL()
 	assert.Equal(
 		t,
-		"unable to load Lacework Content Library: component not installed",
+		"unable to load Lacework Content Library: Lacework Content Library is not installed",
 		err.Error(),
 	)
 }

diff --git a/integration/aws_generation_test.go b/integration/aws_generation_test.go
@@ -159,6 +159,8 @@ func TestGenerationAwsNoninteractive(t *testing.T) {
 		aws.WithCloudtrailUseExistingTrail(true),
 		aws.WithCloudtrailName(cloudtrailName),
 		aws.WithExistingCloudtrailBucketArn(s3BucketArn),
+		aws.WithBucketEncryptionEnabled(true),
+		aws.WithBucketSSEKeyArn(kmsArn),
 		aws.WithCloudtrailUseExistingSNSTopic(true),
 		aws.WithExistingSnsTopicArn(snsTopicArn),
 		aws.WithSnsTopicEncryptionEnabled(true),

diff --git a/lwgenerate/aws/aws.go b/lwgenerate/aws/aws.go
@@ -1058,14 +1058,14 @@ func createCloudtrail(args *GenerateAwsTfConfigurationArgs) (*hclwrite.Block, er
 			if args.BucketName != "" {
 				attributes["bucket_name"] = args.BucketName
 			}
-			if args.BucketEncryptionEnabledSet {
-				if args.BucketEncryptionEnabled {
-					if args.BucketSseKeyArn != "" {
-						attributes["bucket_sse_key_arn"] = args.BucketSseKeyArn
-					}
-				} else {
-					attributes["bucket_encryption_enabled"] = false
+		}
+		if args.BucketEncryptionEnabledSet {
+			if args.BucketEncryptionEnabled {
+				if args.BucketSseKeyArn != "" {
+					attributes["bucket_sse_key_arn"] = args.BucketSseKeyArn
 				}
+			} else {
+				attributes["bucket_encryption_enabled"] = false
 			}
 		}
 		if args.S3BucketNotification {