feat: Lacework ExternalID #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
reviewed
Sep 14, 2023
| @@ -14,13 +14,21 @@ Parameters: | |||
| Invalid resource name prefix. Must match pattern | |||
| ^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*$ | |||
| ExternalID: | |||
| Default: 4CEBE3B | |||
| Default: 4CEBE3BCEB | |||
There was a problem hiding this comment.
@jefferyfry what do you think about making this a random string made of the Stack ID you mentioned? would that be a lot to add? should we just leave this as a fixed string?
|
The lambda functions need to be updated too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://lacework.atlassian.net/browse/GROW-2419
Description
Using the new Lacework External ID format of
lweid:<csp>:<version>:<account_name>:<aws_account_id>:<random_string_size_10>Testing
Tested by uploading to AWS Console.