Update control-tower-integration.template.yaml #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to customer feedback around Lacework broad permissions requests - limit the Sid "StackSetInstanceDelete" permissions to "lacework-*" prefixed resources only. Also break "StackSetInstanceDescribeStackSetOperation" out into its own Sid without the limitation
jvogt
reviewed
Jun 26, 2023
Added missing space to appease the yaml gods
|
@jefferyfry @davymcaleer can you review & approve? This change is on behalf of a customer who asked for additional regulation over what resources can be deleted by the lambda (to prevent any future bugs from deleting non-lw stacksets). This filtering by prefix is tested, and similar to other restrictions by name, which are found elsewhere in the IAM role. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to customer feedback around Lacework broad permissions requests - limit the Sid "StackSetInstanceDelete" permissions to "lacework-*" prefixed resources only.
Also break "StackSetInstanceDescribeStackSetOperation" out into its own Sid without the limitation