Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Filter #22

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Map Filter #22

wants to merge 35 commits into from

Conversation

atan9611
Copy link
Contributor

@atan9611 atan9611 commented Apr 6, 2023

-- Coded basic functionality of the filtering system
-- User clicks on categories (food, shelter, mission, workshop) and clicking apply renders the cards

@atan9611 atan9611 requested a review from he-is-james May 11, 2023 05:09
siddharthnandy
siddharthnandy requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@siddharthnandy siddharthnandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pr, left some comments

mobile/Components/EventCard.js Show resolved Hide resolved
mobile/Components/EventCard.js Show resolved Hide resolved
mobile/Components/EventCard.js Show resolved Hide resolved
mobile/Screen/MapFilter.js Outdated Show resolved Hide resolved
mobile/Screen/MapFilter.js Outdated Show resolved Hide resolved
mobile/Screen/MapFilter.js Show resolved Hide resolved
mobile/Screen/MapFilter.js Show resolved Hide resolved
@atan9611 atan9611 requested a review from siddharthnandy June 7, 2023 03:44
changed eventCategories to an array of strings instead of array of ob…
3322c7c 
…jects, cleaned up reptitive code from PR comments
siddharthnandy
siddharthnandy requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@siddharthnandy siddharthnandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter screen looks great! We need to styler the header; see the AppNavigator.js component to see how to disable the default header, and then you can add your own that matches the Hi-Fis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthnandy siddharthnandy siddharthnandy requested changes

@he-is-james he-is-james Awaiting requested review from he-is-james

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atan9611 @siddharthnandy @he-is-james @zhangjuliet