Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom auth header and user_or_create_function #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support custom auth header and user_or_create_function #5

wants to merge 2 commits into from

Conversation

RenderCoder
Copy link

It is not everyone will write their own UserManager I think (also am I), so it is possible to support user to change their custom user_or_create_function and auth header.

Add:

  • custom user_or_create_function support
  • custom auth header support
    Optimize:
  • the README document content, user can easy to use this tool

@RenderCoder
Add:
f0f5756 
* custom user_or_create_function support
* custom auth header support
Optimize:
* the README document content, user can easy to use this tool
@RenderCoder
Fix: document format error
ecb85a6
@pimvernooij
Copy link
Member

Thanks for this PR!

Could you have a look at:

  • the test suite - all tests fail at the moment
  • declare 'defaults' for the settings you add, so that existing installations can safely upgrade and configuration is not needed when running in default mode?
  • avoid the use of eval() - can you find another way? Eval() is considered bad practise

@RenderCoder
Copy link
Author

Thanks, I'll learn about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenderCoder @pimvernooij