Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding request to user method #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoeButler99
Copy link

Hi everyone, - I needed a method to add the request object to the call to get_or_create_for_cognito. I saw in one of the other pull requests this was also added.

I've created a crude system to do this, now I can receive from this library with
def get_or_create_for_cognito(self, jwt_payload, request):
in my manager model.

I am open to helping any suggestions to doing this in a better/cleaner way. (I'm also quite new to python packaging and its tooling..)

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #21 into master will decrease coverage by 2.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage     100%   97.77%   -2.23%     
==========================================
  Files           3        3              
  Lines          87       90       +3     
  Branches        9       10       +1     
==========================================
+ Hits           87       88       +1     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/django_cognito_jwt/backend.py 95.34% <50%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a30df4...1fe35ca. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #21 into master will decrease coverage by 2.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage     100%   97.77%   -2.23%     
==========================================
  Files           3        3              
  Lines          87       90       +3     
  Branches        9       10       +1     
==========================================
+ Hits           87       88       +1     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/django_cognito_jwt/backend.py 95.34% <50%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a30df4...1fe35ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant