-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparations for first pypi release #396
base: master
Are you sure you want to change the base?
Conversation
…rsed for pypi; more convenient version import also considering post releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a first pass. I'll check out this branch later to see if the sdist looks reasonable!
AUTHORS.txt
Outdated
Michele Ceriotti | ||
Félix Musil | ||
Max Veit | ||
Alexander Goscinski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to sort this file by some alphabetic order? I'm not sure how you generated it =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had some idea behind it, but it seems a bit random. changed to alphabetic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small points and then this should be ready
|
||
Thank you for contributing to libRascal! To make sure your pull request gets | ||
Thank you for contributing to libRascal! To make sure your pull request gets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to libRascal! To make sure your pull request gets | |
Thank you for contributing to librascal! To make sure your pull request gets |
|
||
Build Type | ||
^^^^^^^^^^ | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the underline for the rst header is no longer than the title itself, i.e.
Build Type
^^^^^^^^^^
but if this renders fine it works for me.
Shall we merge this and do the release? Wanted to point someone to using librascal, and it'd be easier if this was just a direct pip install away |
Before doing a release, I would like to fix at least #383, otherwise users with a M1 apple computer will not be able to compile & install librascal. But we should update & merge this PR first! |
Preparation for making the first pypi release with package name librascal #362. You can see the test pypi page https://test.pypi.org/project/librascal/
I have installed it with
and then run the python tests with it to verify that it works
Summary:
./requirements
) this covers issues Dependencies list is duplicated between documentation and requirements.txt #327 Merge requirements.txt or document them better #291AUTHORS.txt
Essential changes, so changes which are not just rascal->librascal, happen in:
TODOs before sending review request
EDIT[14.12.2021]
The README and CONRTIBUTING headers are now following correct header hierarchy
https://stackoverflow.com/a/24504437