-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package name rascal
is already taken on PyPI :(
#362
Comments
rascal
is already taken on PyPI ☹️ rascal
is already taken on PyPI :(
Although we have been using |
I'd go for librascal - it's a C++ library with python bindings and it's
quite common to call c++ libraries libsomething.
…On Mon, 14 Jun 2021 at 14:46, Guillaume Fraux ***@***.***> wrote:
lrascal is not easy to pronounce, but I'll be fine with the other two.
Although we have been using librascal in the group to refer to this code,
it feels a bit strange as a Python module name (from librascal import
SphericalInvariants). Another alternative is lascar, almost reversed =)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#362 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIREZ3SVRK4GTVSVZMGBXDTSX2ZXANCNFSM46VFDIUQ>
.
|
https://pypi.org/project/verlanize/ ? Might be an option for coming up with new package names in the future, provided we start with something that's close to a pronounceable French word |
I think this would be most intuitive— librascal, that is
… On Jun 14, 2021, at 3:22 PM, Michele Ceriotti ***@***.***> wrote:
I'd go for librascal - it's a C++ library with python bindings and it's
quite common to call c++ libraries libsomething.
On Mon, 14 Jun 2021 at 14:46, Guillaume Fraux ***@***.***>
wrote:
> lrascal is not easy to pronounce, but I'll be fine with the other two.
>
> Although we have been using librascal in the group to refer to this code,
> it feels a bit strange as a Python module name (from librascal import
> SphericalInvariants). Another alternative is lascar, almost reversed =)
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#362 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAIREZ3SVRK4GTVSVZMGBXDTSX2ZXANCNFSM46VFDIUQ>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#362 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKVP3SFQ62P6UO47HOSPMLTSX7ANANCNFSM46VFDIUQ>.
|
I also think we should change the python module name to match the name on pypi, i.e. This would be a breaking change for all current users, but should be relatively easy to fix. |
We have an external user who has been struggling for two days because of this. I'd say we need to act. |
After a conversation with @max-veit I realized that the only thing, which will not be backwards compatible due to #376, are cpp representations. I don't think any python user tries to make a cpp representation directly, circumventing the python representation classes. The remaining changes in #305 only add supplementary information to the fitting file. So I think we can actually make a release. |
Excellent. Can you do that? I'll then update all branches and side-projects: will be a couple of weeks of pain, but I think it's for the greater good. |
Before making a release, I think we should re-license to LGPL-v2 or later (#303). I can take care of this if everyone is fine with it. |
Jolly good.
…On Thu, 9 Dec 2021 at 10:29, Guillaume Fraux ***@***.***> wrote:
Before making a release, I think we should re-license to LGPL-v2 or later (
#303 <#303>). I can take
care of this if everyone is fine with it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#362 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIREZ3GVFR4WDXEW2ZHA2DUQBZGDANCNFSM46VFDIUQ>
.
|
https://pypi.org/project/rascal/ has the same Python package name as ours (both do
import rascal
) - so basically, we need to rename ourrascal
python package to avoid any potential future conflict with this existing spectroscopy library. I would be fine withlibrascal
,lrascal
, or evenlilrascal
(as suggested by @rosecers ).The text was updated successfully, but these errors were encountered: