Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name rascal is already taken on PyPI :( #362

Open
max-veit opened this issue Jun 14, 2021 · 11 comments
Open

Package name rascal is already taken on PyPI :( #362

max-veit opened this issue Jun 14, 2021 · 11 comments
Labels
maintenance Code cleanup and "cosmetic" improvements

Comments

@max-veit
Copy link
Contributor

https://pypi.org/project/rascal/ has the same Python package name as ours (both do import rascal) - so basically, we need to rename our rascal python package to avoid any potential future conflict with this existing spectroscopy library. I would be fine with librascal, lrascal, or even lilrascal (as suggested by @rosecers ).

@max-veit max-veit added the maintenance Code cleanup and "cosmetic" improvements label Jun 14, 2021
@max-veit max-veit changed the title Package name rascal is already taken on PyPI ☹️ Package name rascal is already taken on PyPI :( Jun 14, 2021
@Luthaf
Copy link
Contributor

Luthaf commented Jun 14, 2021

lrascal is not easy to pronounce, but I'll be fine with the other two.

Although we have been using librascal in the group to refer to this code, it feels a bit strange as a Python module name (from librascal import SphericalInvariants). Another alternative is lascar, almost reversed =)

@ceriottm
Copy link
Contributor

ceriottm commented Jun 14, 2021 via email

@max-veit
Copy link
Contributor Author

Another alternative is lascar, almost reversed =)

https://pypi.org/project/verlanize/ ? Might be an option for coming up with new package names in the future, provided we start with something that's close to a pronounceable French word

@rosecers
Copy link
Contributor

rosecers commented Jun 14, 2021 via email

@Luthaf
Copy link
Contributor

Luthaf commented Jun 14, 2021

I also think we should change the python module name to match the name on pypi, i.e. from librascal import XXX instead of from rascal import XXX. While this is not mandatory, it would remove some confusion on the user side who see some script starting with import rascal, then do pip install rascal and the code still fails.

This would be a breaking change for all current users, but should be relatively easy to fix.

@ceriottm
Copy link
Contributor

ceriottm commented Nov 11, 2021

We have an external user who has been struggling for two days because of this. I'd say we need to act.
I suggest s/rasca/librascal and put it on pipy ASAP. we've already being referring to the package as librascal, so it's the most painless renaming we can do at this stage. I can see both pros and cons in renaming the package itself, as opposed to using "librascal" on pipy. given the existence of an unrelated package, I think that a full renaming is better. "lascar" [library for atomic scale representations] is also pretty good but a more substantial change of branding...

@agoscinski
Copy link
Contributor

agoscinski commented Dec 6, 2021

Hello, before adding librascal to pypi, it makes sense to me that we have a stable model json format. The PRs #305 and #376 add significant changes to it. So I suggest to get these two merged before making a release.

EDIT: also PR #353

@agoscinski
Copy link
Contributor

After a conversation with @max-veit I realized that the only thing, which will not be backwards compatible due to #376, are cpp representations. I don't think any python user tries to make a cpp representation directly, circumventing the python representation classes. The remaining changes in #305 only add supplementary information to the fitting file.

So I think we can actually make a release.

@ceriottm
Copy link
Contributor

ceriottm commented Dec 6, 2021

Excellent. Can you do that? I'll then update all branches and side-projects: will be a couple of weeks of pain, but I think it's for the greater good.

@Luthaf
Copy link
Contributor

Luthaf commented Dec 9, 2021

Before making a release, I think we should re-license to LGPL-v2 or later (#303). I can take care of this if everyone is fine with it.

@ceriottm
Copy link
Contributor

ceriottm commented Dec 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code cleanup and "cosmetic" improvements
Projects
None yet
Development

No branches or pull requests

5 participants