Fix for issue #6 and one other error #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If delivery failed due to a SMTPNotSupportedError exception, the exception handler in _deliver would try to invoke the decode() method on the class object, resulting in a cascading error. This commit fixes that problem.
Using mailproxy with Python 3.7+ results in the following error when s.starttls() is called: ValueError: server_hostname cannot be an empty string or start with a leading dot. The workaround for this problem is to pass the target host and port to the smtplib.SMTP() or smtplib.SMTP_SSL() constructors.
dancysoft
changed the title
Avoid a cascading error by catching and ignoring smtplib.SMTPServerDisconnected error when processing the 'finally' clause of MailProxyHandler._deliver().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If delivery failed due to a SMTPNotSupportedError exception, the
exception handler in _deliver would try to invoke the decode() method
on the class object, resulting in a cascading error. This commit
fixes that problem.