Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[Feature] : Halt testing upon the first failure #31

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

shubham-cmyk
Copy link
Member

What this PR does / why we need it:

This PR would skip all the Further Testing if any of the test failed if user passed the field stopOnFirstFailure to be true

It is much needed as it prevents waste of time and processing in order for a user/contributor to know what may be broken and requires remediation.

Fixes #26

Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
Copy link
Member Author

@chipzoller @eddycharly Check out

simply taking a field stopOnFirstFailure from the user's skip all the further testing if found any error in the test.

@shubham-cmyk
Copy link
Member Author

@chipzoller I think this is what was probably required.
Any feedback would help a lot

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@eddycharly
Copy link
Member

So basically it skips tests when a failure happens ?

@shubham-cmyk
Copy link
Member Author

Yes. The requirements was discussed in the issue #26

Copy link
Member

@eddycharly eddycharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@eddycharly eddycharly merged commit 1e404d2 into kyverno:main Aug 29, 2023
5 checks passed
@shubham-cmyk shubham-cmyk deleted the halt branch August 29, 2023 10:45
@chipzoller
Copy link

@shubham-cmyk @eddycharly, as these issues are closed and features are added, we must ensure we document them in Kyverno's fork of kuttl. I'm glad to do some refactoring of the README, but for now let's start a separate Markdown file in the root with the changes we're adding so we don't forget. You should make this a requirement for this mentorship, Charles.

@shubham-cmyk
Copy link
Member Author

shubham-cmyk commented Aug 29, 2023

@chipzoller @eddycharly What columns would you consider in a readme.md
Would you consider something like below where we can maybe mark the issue, PR with the description

Issues & PRs Tracker

Issue # PR # Description
#26 #31 Halt testing upon the first failure
2 6 Fix ..........
3 7 Add ...........
... ... ...

@chipzoller
Copy link

Anything works right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Parameter to halt testing upon the first failure
3 participants