-
Notifications
You must be signed in to change notification settings - Fork 5
[Feature] : Halt testing upon the first failure #31
Conversation
Signed-off-by: Shubham Gupta <[email protected]>
@chipzoller @eddycharly Check out simply taking a field |
@chipzoller I think this is what was probably required. |
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
So basically it skips tests when a failure happens ? |
Yes. The requirements was discussed in the issue #26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
@shubham-cmyk @eddycharly, as these issues are closed and features are added, we must ensure we document them in Kyverno's fork of kuttl. I'm glad to do some refactoring of the README, but for now let's start a separate Markdown file in the root with the changes we're adding so we don't forget. You should make this a requirement for this mentorship, Charles. |
@chipzoller @eddycharly What columns would you consider in a readme.md Issues & PRs Tracker
|
Anything works right now. |
What this PR does / why we need it:
This PR would skip all the Further Testing if any of the test failed if user passed the field
stopOnFirstFailure
to be trueIt is much needed as it prevents waste of time and processing in order for a user/contributor to know what may be broken and requires remediation.
Fixes #26