use the file extension given by yt-dlp instead of assuming mp4

kytpbs · Aug 11, 2024 · 9a39085 · 9a39085
1 parent c72cd1b
commit 9a39085
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Youtube.py b/src/Youtube.py
@@ -118,9 +118,13 @@ def download_video_from_link(url: str, path: str | None = None) -> VIDEO_RETURN_
 
         info = ydt.get("entries", [None])[0] or ydt
         video_id = info["id"]
+        video_extension = info["ext"]
         if video_id is None:
             return []
 
-        file_path = os.path.join(path, f"{video_id}.mp4")
+        if video_extension != "mp4":
+            logging.error("Got a non-mp4 file that is %s from this link: %s", video_extension, url)
+
+        file_path = os.path.join(path, f"{video_id}.{video_extension}")
 
         return [VideoFile(file_path, info.get("title", None))]