Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected algorithm of ofxCv::thin() #184

Closed
wants to merge 1 commit into from

Conversation

roymacdonald
Copy link
Contributor

I'm not sure if this is the most efficient way of performing this but it works so far. It is performing several thinning passes until there's nothing more to thin, thus just leaving the skeleton. My guess is that this is the idea instead of just performing a single pass.

@roymacdonald
Copy link
Contributor Author

related to #183

@kylemcdonald
Copy link
Owner

this looks promising but all those memcpys make me nervous. if you can do this with opencv's copy (or ofxCv::copy which wraps it) that would be better.

there's also a lot of room for optimization, but maybe that's a separate PR ;) e.g., see https://sites.google.com/site/rameyarnaud/research/c/voronoi

@roymacdonald
Copy link
Contributor Author

yes, I don't like all those memcpy too! This is like the straightforwards implementation but certainly
there's a lot of room for optimizing.
Isn't ofxCv::copy a bit overkill for this situation? which, I'm not sure but I guess, might slow down the algorithm.
I'll check the whole thing and look for a good optimization on a few days as right now I cant.
Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants