Update textgrid.py

[lcavasso]

Changed logic in IntervalTier.intervalContaining() so that you can check for times that are less than 1 without returning None.

Suppose mygrid is a TextGrid with a duration of greater than 0.1 seconds. mygrid[0].intervalContaining(0.1) would previously return None. It seems 0.1 is somehow evaluating to False

Addresses issue #38

[kylebgorman]

Hi Luca, thanks for this. I see the issue you mention.

I wonder if you could add a test to tests.py that covers this bug...i.e., something that previously failed and now succeeds. (We should do more test automation and such here but we wrote this library over a decade ago, before such things were standard practice.)

[lcavasso]

Sure, I can give that a try. Also, while working on this I realized I was confused before - the bug is actually that since 0 evaluates as False, intervalContaining can't return the first interval. (It checks whether the index i is None just by if i, so where i is 0, whatever's under the if statement will never execute.)

[lcavasso]

Test added!

[kylebgorman]

Thanks, that's all we need. Merging now.

If I may, feel free to continue to contribute here...

[lcavasso]

Hi Kyle, would you mind updating PyPi so that pip install textgrid includes this fix?

[kylebgorman]

Sure, or if you want to I could make you a maintainer on PyPI?

[lcavasso]

Sure! I don't really have experience with PyPi, but I'm sure I can figure it out. I just made a PyPi profile: https://pypi.org/user/lcavasso/

[kylebgorman]

You have been sent an invite.

…

On Tue, Mar 5, 2024 at 1:02 PM Luca Cavasso ***@***.***> wrote: Sure! I don't really have experience with PyPi, but I'm sure I can figure it out. I just made a PyPi profile: https://pypi.org/user/lcavasso/ — Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABG4OIEALIODVJK5KB6N3LYWYCD5AVCNFSM6AAAAAA7BVU5NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGMZTSNZXGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>