-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makeanimationupdate #523
base: master
Are you sure you want to change the base?
Makeanimationupdate #523
Conversation
hi @thekester , sorry I took 3 weeks to review this. I like the PR so that we don't get that warning anymore but I prefer not to add another module like |
Since |
thanks! will test it |
@thekester , was wondering why we need to resize the image to 2864, 1440? this may create animations that are quite large no? |
Please feel free to choose the most appropriate size; the example provided |
@thekester , I'm not convince about the resizing as every ROI has a different aspect ratio, some beaches are E or W facing while other are N or S facing, then if you resize all the images to a fixed size it will not work. I am happy to live with the warning as it seems to create good quality clips anyways. But if you want to resize, I suggest you find the most common size in the image folder and use that size for resizing all the images. It can happen that some satellite images are clipped, hence the difference in size that ffpmeg doesn't like.
|
Thank you for your feedback, @kvos. I hadn't considered the issue of different aspect ratios due to the varying orientations of the beaches—this is a great point. I'll look into a method to automatically detect the aspect ratio of each image, identifying whether the beaches are oriented East-West or North-South. Then, I can adjust the resizing process to maintain the original proportions of the images while still avoiding the IMAGEIO FFMPEG warnings. I'll test this approach and add a commit if it works. |
Hello, this pull request addresses issue #522 by adding new functionality to create and update animations from a series of images. It includes the following key changes:
Changes made in SDS_tools and include 2 libraries
import cv2 from PIL import Image
to implement them, replacepip install pyqt5 imageio-ffmpeg
withpip install pyqt5 imageio-ffmpeg opencv-python Pillow