Hash join flatten fix #4668
Merged
Hash join flatten fix #4668
+19
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultMaster commit hash:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4668 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 1373 1373
Lines 58273 58267 -6
Branches 7231 7226 -5
=======================================
- Hits 50465 50460 -5
+ Misses 7642 7641 -1
Partials 166 166 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Dec 28, 2024
| @@ -165,6 +165,24 @@ binder::expression_vector LogicalHashJoin::getJoinNodeIDs( | |||
| return result; | |||
| } | |||
|
|
|||
| class JoinNodeIDUniquenessAnalyzer { | |||
| public: | |||
| bool isUnique(LogicalOperator* op, const binder::Expression& joinNodeID) { | |||
There was a problem hiding this comment.
Why not make this function static?
andyfengHKU
force-pushed
the
hash-join-flatten-fix
branch
from
41c6449 to
7e84af4
Compare
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in hash join planning exposed in PR #4625. Below is a description of the bug.
We append flatten to probe side if and only if join key is an internal ID and this ID is guaranteed to be unique on the build side. The check was done based on number of factorization group. This is not true if an aggregation happens, which will always reduce the number of factorization group to 1.
This PR checks by looking at operators along the build side subplan.
Testing
The bug cannot be revealed easily on master because we don't reorder multi-part queries. So aggregation does not happen on build side. I have tested by cherry-picking to #4625.
Fixes # (issue)
Contributor agreement