Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TSAN and fixes #3337

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enable TSAN and fixes #3337

wants to merge 4 commits into from

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 22, 2024

No description provided.

@ray6080 ray6080 changed the title Fix tsan Enable TSAN and fixes Apr 23, 2024
@ray6080 ray6080 force-pushed the fix-tsan branch 2 times, most recently from 4941eff to 8881764 Compare April 27, 2024 05:26
@ray6080 ray6080 marked this pull request as ready for review April 27, 2024 05:27
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.04%. Comparing base (b88aca1) to head (365d83e).

Files Patch % Lines
src/include/processor/operator/mask.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
- Coverage   85.15%   85.04%   -0.12%     
==========================================
  Files        1297     1297              
  Lines       50514    50512       -2     
  Branches     6955     6954       -1     
==========================================
- Hits        43016    42958      -58     
- Misses       7368     7423      +55     
- Partials      130      131       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 5, 2024

Benchmark Result

Master commit hash: b88aca112024631118b667bbe41441a542347475
Branch commit hash: 0023df2258426fc6d9a0a7cc8de3a340f2265e6c

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 684.34 684.84 -0.50 (-0.07%)
aggregation q28 11284.21 12119.40 -835.20 (-6.89%)
filter q14 158.17 160.90 -2.73 (-1.70%)
filter q15 161.42 159.48 1.95 (1.22%)
filter q16 338.60 334.71 3.89 (1.16%)
filter q17 481.07 481.08 -0.01 (-0.00%)
filter q18 1967.99 1960.56 7.43 (0.38%)
fixed_size_expr_evaluator q07 572.07 571.87 0.20 (0.03%)
fixed_size_expr_evaluator q08 786.26 786.68 -0.42 (-0.05%)
fixed_size_expr_evaluator q09 780.45 785.94 -5.49 (-0.70%)
fixed_size_expr_evaluator q10 273.72 273.14 0.58 (0.21%)
fixed_size_expr_evaluator q11 268.28 267.41 0.87 (0.33%)
fixed_size_expr_evaluator q12 267.36 266.59 0.77 (0.29%)
fixed_size_expr_evaluator q13 1501.43 1504.77 -3.34 (-0.22%)
fixed_size_seq_scan q23 151.42 150.88 0.54 (0.36%)
join q31 46.66 52.73 -6.07 (-11.51%)
ldbc_snb_ic q35 3856.17 3690.90 165.26 (4.48%)
ldbc_snb_ic q36 132.49 130.27 2.22 (1.70%)
ldbc_snb_is q32 10.22 9.66 0.56 (5.78%)
ldbc_snb_is q33 90.05 97.21 -7.16 (-7.37%)
ldbc_snb_is q34 98.75 79.92 18.83 (23.56%)
multi-rel multi-rel-large-scan 3254.33 2777.88 476.45 (17.15%)
multi-rel multi-rel-lookup 55.51 80.21 -24.70 (-30.79%)
multi-rel multi-rel-small-scan 58.04 62.56 -4.53 (-7.24%)
order_by q25 164.76 164.96 -0.20 (-0.12%)
order_by q26 487.14 499.50 -12.36 (-2.48%)
order_by q27 1439.08 1432.58 6.50 (0.45%)
scan_after_filter q01 205.27 207.78 -2.52 (-1.21%)
scan_after_filter q02 195.60 196.56 -0.96 (-0.49%)
shortest_path_ldbc100 q39 93.11 93.81 -0.70 (-0.74%)
var_size_expr_evaluator q03 2101.50 2097.71 3.78 (0.18%)
var_size_expr_evaluator q04 2314.50 2317.44 -2.95 (-0.13%)
var_size_expr_evaluator q05 2647.29 2575.45 71.85 (2.79%)
var_size_expr_evaluator q06 1356.42 1367.18 -10.76 (-0.79%)
var_size_seq_scan q19 1498.40 1498.41 -0.00 (-0.00%)
var_size_seq_scan q20 3199.17 3216.88 -17.70 (-0.55%)
var_size_seq_scan q21 2459.71 2528.56 -68.86 (-2.72%)
var_size_seq_scan q22 136.53 138.40 -1.87 (-1.35%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant