Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global.Node matches polyfill #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NoMaillard
Copy link

matches is not a method on a Node only on an Element

`matches` is not a method on a `Node` only on an `Element`
@rahim
Copy link

rahim commented Jun 26, 2020

It would be great to see this merged - I've just hit exactly this issue, where a third party script (from VWO) has been throwing errors because it assumes matches would be defined on Element, but not Node (or Document which is a descendant) matching the DOM specs:

smooth-dnd itself uses matches only once (here) and the TypeScript implies it's only ever used on Element so the change should be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants