This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Updated staking page instructions #112
Open
dreecer1
wants to merge
1
commit into
kusamanetwork:master
Choose a base branch
from
dreecer1:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @laboon - I went to stake on Kusama today and couldn't find any instructions on how to nominate. My path was Google>"How to stake on Kusama">I found the "Staking" page on this guide, but what I really needed was the "Nominating" page. The whole industry uses the word staking instead of nominating, so this could cause some issues. I was only able to nominate after I found a medium article buried on the Kusama forum. I'm just updating this page to add a couple call-outs to the Nominating instructions in case other people do the same thing I did.
Swader
suggested changes
Jan 19, 2020
@@ -4,6 +4,8 @@ Kusama uses NPoS (Nominated Proof-of-Stake), comprising the roles of validators | |||
|
|||
Both validators and nominators will earn rewards— and may be penalized—proportional to the amount that they stake, with validators having the ability to set some payment preferences. | |||
|
|||
For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide. | |
For detailed instructions on how to nominate a validator, which can be seen as staking your KSM tokens _through_ someone else, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide. |
I wouldn't indicate that nominating and staking are interchangeable. Validators stake, nominators nominate. I do agree it might be confusing for newcomers, but we need to make the distinction clearer, not merge terms.
Makes sense. We could just take out "often referred to as staking" but I
still think we need to link back over to Nominating from this page to avoid
confusion.
…On Sun, Jan 19, 2020 at 3:26 AM Bruno Škvorc ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In docs/try/staking.md
<#112 (comment)>
:
> @@ -4,6 +4,8 @@ Kusama uses NPoS (Nominated Proof-of-Stake), comprising the roles of validators
Both validators and nominators will earn rewards— and may be penalized—proportional to the amount that they stake, with validators having the ability to set some payment preferences.
+For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
⬇️ Suggested change
-For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
+For detailed instructions on how to nominate a validator, which can be seen as staking your KSM tokens _through_ someone else, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
I wouldn't indicate that nominating and staking are interchangeable.
Validators stake, nominators nominate. I do agree it might be confusing for
newcomers, but we need to make the distinction clearer, not merge terms.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#112?email_source=notifications&email_token=ANWBQ2TDI4MVA7QN6L723JLQ6QMCVA5CNFSM4KIVMOUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSIBXAQ#pullrequestreview-344988546>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANWBQ2VHMV7Q6NOF2OZLYTLQ6QMCVANCNFSM4KIVMOUA>
.
|
Agreed re link back everywhere. The pages should cross link as much as possible
Sent from ProtonMail mobile
…-------- Original Message --------
On Jan 19, 2020, 19:52, dreecer1 wrote:
Makes sense. We could just take out "often referred to as staking" but I
still think we need to link back over to Nominating from this page to avoid
confusion.
On Sun, Jan 19, 2020 at 3:26 AM Bruno Škvorc ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
> ------------------------------
>
> In docs/try/staking.md
> <#112 (comment)>
> :
>
> > @@ -4,6 +4,8 @@ Kusama uses NPoS (Nominated Proof-of-Stake), comprising the roles of validators
>
>
>
> Both validators and nominators will earn rewards— and may be penalized—proportional to the amount that they stake, with validators having the ability to set some payment preferences.
>
>
>
> +For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
>
>
> ⬇️ Suggested change
>
> -For detailed instructions on how to nominate a validator, often referred to as staking, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
>
> +For detailed instructions on how to nominate a validator, which can be seen as staking your KSM tokens _through_ someone else, please see the [Nominating page](https://guide.kusama.network/en/latest/try/nominating/) of this guide.
>
>
> I wouldn't indicate that nominating and staking are interchangeable.
> Validators stake, nominators nominate. I do agree it might be confusing for
> newcomers, but we need to make the distinction clearer, not merge terms.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#112?email_source=notifications&email_token=ANWBQ2TDI4MVA7QN6L723JLQ6QMCVA5CNFSM4KIVMOUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSIBXAQ#pullrequestreview-344988546>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANWBQ2VHMV7Q6NOF2OZLYTLQ6QMCVANCNFSM4KIVMOUA>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#112?email_source=notifications&email_token=AAK5IS6TXUSC46ZVC45AH5DQ6SOQVA5CNFSM4KIVMOUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKZOLY#issuecomment-576034607), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAK5IS2DEJJROVVWYBRJC2DQ6SOQVANCNFSM4KIVMOUA).
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @laboon - I went to stake on Kusama today and couldn't find any instructions on how to nominate. My path was Google>"How to stake on Kusama">I found the "Staking" page on this guide, but what I really needed was the "Nominating" page. The whole industry uses the word staking instead of nominating, so this could cause some issues for new users. I was only able to nominate after I found a medium article buried on the Kusama forum. I'm just updating this page to add a couple call-outs to the Nominating instructions in case other people do the same thing I did.