Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Gateway Plugin Support #691

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Docs: Add Gateway Plugin Support #691

merged 2 commits into from
Oct 10, 2024

Conversation

Gidi233
Copy link
Contributor

@Gidi233 Gidi233 commented Sep 13, 2024

What type of PR is this?
/kind documentation

Which issue(s) this PR fixes:
a part of #651

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit aaca1d5
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/67064e3ab0c41b0008810fc5

@@ -331,6 +347,105 @@ If the status shows as `Initialized`, it means the initialization of rollout pro

**Notes**: In the above configuration, we set the `kustomization.interval` to 0s. This disables Fluxcd's periodic synchronization of configurations between the local mirror and cluster. The reason is that Flagger needs to modify the replica counts in Deployments to complete its initialization process. If you are uncertain whether the replicas for all applications in your deployments are set to zero, it is recommended to also set `kustomization.interval` to 0s.

### Using Nginx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be added in the same usage document. It should add another three level catalogue
Abtest, Blue-Green Deploy and Canary.
Documentation according to different ingresses in three directories

@LiZhenCheng9527
Copy link
Contributor

I have submitted a PR #693. After the PR has been merged in, you split the content of the document and write the document in accordance with different ingress.

@LiZhenCheng9527
Copy link
Contributor

/lgtm

Signed-off-by: Gidi233 <[email protected]>
@Gidi233
Copy link
Contributor Author

Gidi233 commented Oct 9, 2024

/lgtm

@kurator-bot
Copy link
Collaborator

@Gidi233: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiZhenCheng9527
Copy link
Contributor

/lgtm

@LiZhenCheng9527
Copy link
Contributor

@hzxuzhonghu PTAL

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit ac68f35 into kurator-dev:main Oct 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants