Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: init migrate webhook #412

Closed
wants to merge 1 commit into from

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Oct 23, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

part of #404

add webhook validation for migrate

since using the sam common func of backup webhook, this pr is rely on #410

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

backup: init migrate webhook

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 7d3a678
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/6536697c9c17b90008978ef4

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member

can we consider removing the webhook if Kubernetes CEL work here

@Xieql
Copy link
Contributor Author

Xieql commented Dec 2, 2023

can we consider removing the webhook if Kubernetes CEL work here

yes

@Xieql Xieql closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants