Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: update design of destination #384

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Sep 14, 2023

What type of PR is this?

/kind api-change

/kind design

What this PR does / why we need it:

the design of destination is changed,

so we need update api

ref #377

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for kurator-dev ready!

Name Link
🔨 Latest commit 8ce7eec
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/6503003f05b86e0008feb5f8
😎 Deploy Preview https://deploy-preview-384--kurator-dev.netlify.app/references/backups_v1alpha1_types
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kurator-bot
Copy link
Collaborator

@Xieql: The label(s) kind/design cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind api-change

/kind design

What this PR does / why we need it:

the design of destination is changed,

so we need update api

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 5734bb7 into kurator-dev:main Sep 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants