Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Drummer Kit game 🥁 #5163

Merged
merged 7 commits into from
Aug 10, 2024
Merged

Adds Drummer Kit game 🥁 #5163

merged 7 commits into from
Aug 10, 2024

Conversation

SanskarSinghiit
Copy link
Contributor

Fixes #5159

PR Description 📜

Create a virtual drum kit game where players can hit drum pads to play beats and rhythms.
Features include rhythm challenges, custom beats, and practice mode.


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

image



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Aug 10, 2024

Thank you @SanskarSinghiit ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@SanskarSinghiit SanskarSinghiit changed the title A Adds Drummer Kit game 🥁 Aug 10, 2024
@SanskarSinghiit
Copy link
Contributor Author

@ishita-43 mam, please review this PR.

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Aug 10, 2024
@SanskarSinghiit
Copy link
Contributor Author

Thank you

@kunjgit
Copy link
Owner

kunjgit commented Aug 10, 2024

@SanskarSinghiit resolve merge conflicts !

@kunjgit kunjgit merged commit 3c7f558 into kunjgit:main Aug 10, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 10, 2024

Thank you @SanskarSinghiit , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Add Drummer Kit game 🥁
3 participants