Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated game link in README.md for Sky Lift Dash Game 🎮 #5127

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

SanskarSinghiit
Copy link
Contributor

PR Description 📜

This Pull Request addresses issue #5110.
It introduces a new game titled Sky Lift Dash, to the repository, with the following updates.

  1. Implemented the core game logic where players navigate a ball through a moving gap in horizontal walls.
  2. Added dynamic wall movement and gravity mechanics.
  3. Included a scoring system and game-over conditions.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

Screenshot 2024-08-06 191307


Thank you soo much for contributing to our repository 💗

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Adds Sky_Lift_Dash game
index.html is in root folder of the Sky_Lift_Dash game folder
root folder has README.md file, including description and screenshots

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Adds the game image to assets/images folder with the exact same name.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kunjgit
Copy link
Owner

kunjgit commented Aug 7, 2024

Thank you @SanskarSinghiit ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@SanskarSinghiit
Copy link
Contributor Author

@ishita-43
Mam, I have followed the Contributing guideline thoroughly.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make this little change in your readme file and upload that to this pr

README.md Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor Author

@SanskarSinghiit SanskarSinghiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files reviewed.

@SanskarSinghiit
Copy link
Contributor Author

SanskarSinghiit commented Aug 8, 2024

@ishita-43 Mam I have updated my game link in README.md.
Thankyou for your valuable guidance.

@SanskarSinghiit SanskarSinghiit changed the title Adds Sky Lift Dash Game 🎮 Updated game link in README.md for Sky Lift Dash Game 🎮 Aug 8, 2024
@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Aug 8, 2024
@kunjgit kunjgit merged commit 17fd14b into kunjgit:main Aug 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 8, 2024

Thank you @SanskarSinghiit , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants