Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added number sorting game #5123

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Added number sorting game #5123

merged 9 commits into from
Aug 9, 2024

Conversation

AmruthaPariprolu
Copy link
Contributor

@AmruthaPariprolu AmruthaPariprolu commented Aug 7, 2024 •
edited
Loading

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #5120

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Aug 7, 2024

Thank you @AmruthaPariprolu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43
Copy link
Collaborator

What is your issue number

ishita-43
ishita-43 requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines which are unnecessary in readme file and only include your game entry

README.md Outdated
@@ -1710,6 +1710,10 @@ This repository also provides one such platforms where contributers come over an
add/find-the-missing-letter
=======
|[Cross_Road_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Cross_Road_Game)|
add/number-sorting-game
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

README.md Outdated
@@ -1710,6 +1710,10 @@ This repository also provides one such platforms where contributers come over an
add/find-the-missing-letter
=======
|[Cross_Road_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Cross_Road_Game)|
add/number-sorting-game
|[Number_Sorting_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Number_Sorting_Game)|
=======
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

README.md Outdated
add/number-sorting-game
|[Number_Sorting_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Number_Sorting_Game)|
=======
main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

@AmruthaPariprolu
Copy link
Contributor Author

@ishita-43 done

ishita-43
ishita-43 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Aug 9, 2024
@kunjgit kunjgit merged commit ec44c32 into kunjgit:main Aug 9, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 9, 2024

Thank you @AmruthaPariprolu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: add number sorting game
3 participants
@AmruthaPariprolu @kunjgit @ishita-43