Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gem cruncher #5054

Merged
merged 5 commits into from
Aug 6, 2024
Merged

added gem cruncher #5054

merged 5 commits into from
Aug 6, 2024

Conversation

Aditijainnn
Copy link
Contributor

@Aditijainnn Aditijainnn commented Jul 31, 2024

Fixes # <your_issue_number>
#4436


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

353724741-315b6597-bdfd-403f-a708-ea46e9850e8f



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 31, 2024

Thank you @Aditijainnn ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Aditijainnn
Copy link
Contributor Author

i have raised new pr and updated readme file also please check

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your game image in asset folder of the repo follow naming convention while naming that image

@Aditijainnn
Copy link
Contributor Author

Add your game image in asset folder of the repo follow naming convention while naming that image

done please merge my pr

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Aug 2, 2024
@Aditijainnn
Copy link
Contributor Author

please merge

@ishita-43
Copy link
Collaborator

please merge

Merge will be proceeded by the admin soon!

@Aditijainnn
Copy link
Contributor Author

ok

@ishita-43
Copy link
Collaborator

Please resolve merge conflicts

@Aditijainnn
Copy link
Contributor Author

Done resolved them

@kunjgit kunjgit merged commit 7dad6b1 into kunjgit:main Aug 6, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 6, 2024

Thank you @Aditijainnn , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants