Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functional dark/light theme toggle button and update relat… #5031

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

PRASANNA-THE-PRASANN1
Copy link
Contributor

@PRASANNA-THE-PRASANN1 PRASANNA-THE-PRASANN1 commented Jul 30, 2024

…ed files

PR Description 📜

i have removed the non functioning switch button for light and dark mode and hence updated relevant files
Kindly review and merge my pull request @ishita-43 @kunjgit
Fixes # <4978>

Mark the task you have completed ✅

deleted non non functioning switch button for light and dark mode on header ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [x ] I have performed a self-review of my own code or work.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [ x] My changes generates no new warnings.
  • [x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [x ] I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

Screenshot 2024-07-30 181044



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 30, 2024

Thank you @PRASANNA-THE-PRASANN1 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr is approved

@ishita-43 ishita-43 added level1 Documentation and small bug fixes in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 30, 2024
@kunjgit kunjgit merged commit 5153250 into kunjgit:main Jul 31, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 31, 2024

Thank you @PRASANNA-THE-PRASANN1 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants