Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Super tetris game #5005

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Added Super tetris game #5005

merged 8 commits into from
Jul 31, 2024

Conversation

pavitraag
Copy link
Contributor

PR Description 📜

Fixes # 5002

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

image

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 28, 2024

Thank you @pavitraag ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

ishita-43
ishita-43 requested changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make following changes
Add your game entry in main readme. Md file of the gamezone repo
Add your game image in asset folder of the repo follow naming convention while naming the image

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 28, 2024
@ishita-43
Copy link
Collaborator

Please make following changes Add your game entry in main readme. Md file of the gamezone repo Add your game image in asset folder of the repo follow naming convention while naming the image

Ready to merge

@pavitraag
Copy link
Contributor Author

@kunjgit can u please merge it

@pavitraag
Copy link
Contributor Author

@kunjgit can u please merge this so that i can raise my next issue

@pavitraag
Copy link
Contributor Author

@kunjgit please review my pr and merge it

@kunjgit kunjgit merged commit 0c07353 into kunjgit:main Jul 31, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 31, 2024

Thank you @pavitraag , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavitraag @kunjgit @ishita-43