Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive Website Enhancements: Fix Game Loading, Pagination, Layout Issues, JSON Errors, Cursor Size, and Remove Redundant File #4975

Merged
merged 9 commits into from
Jul 28, 2024
Merged

Comprehensive Website Enhancements: Fix Game Loading, Pagination, Layout Issues, JSON Errors, Cursor Size, and Remove Redundant File #4975

merged 9 commits into from
Jul 28, 2024

Conversation

mohitgedar
Copy link
Contributor

PR Description 📜

Fixes #4974

  • I have Improved game loading functionality to ensure all games are loading and accessible to users. This enhancement will increase user satisfaction by providing a seamless and reliable gaming experience.
  • I have made changes so that pagination system is working again to facilitate smooth navigation between games. This will improve the user experience by making it easier to browse and discover content.
  • I have Redesigned the like button layout to prevent it from overlapping with the game titles and also added hover effect to make it visually appealing. This will enhance the visual layout and ensure that all interactive elements are clearly accessible and aesthetically pleasing.
  • I have also added hover effect to the Game Title , so that it get highlighted on mouse hover, indicating that it is a link to the code of the game
  • I have Updated the contributors' guidelines to include clear instructions on proper JSON formatting, this time I used better markups to make it visually appealing and added some more points to counter new problems users are facing.
  • I have reduced the size of the manual cursor to improve visibility and usability. This adjustment will ensure that the cursor does not obstruct important content, enhancing the overall user experience.
  • I have Removed the unused index_old.html file to reduce load times and improve website performance. This will optimize the website’s efficiency and enhance the user experience. Screenshot of loadtime is also added for your reference

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Before deletion of file load time is 42ms.

before deleting old_html file

After deletion of file load time is 33ms.

after deleting old_html file

Check game 24 , no overlapping and with hover effect ( cursor not visible in SS )

GameZone - Brave 25-07-2024 12 08 04 PM
GameZone - Brave 25-07-2024 12 08 08 PM


Thank you soo much for contributing to our repository 💗

@mohitgedar
Updated contributing guidline
9685bdd 
I have updated contribution guidlines to add note about mistake that contributors are making to add the game to gamesData.json
@mohitgedar
updated script.js
3a41138 
I have updated script.js to remove bug of pagination for games not working properly
@mohitgedar
updated gamesData.json
af1dd8f 
I have updated GamesData.json so that the key no. that was not used , i.e 570 is not used , so last game also loads, and removed the syntax error again , also moved the atlas game to its previous position
@mohitgedar
deleted index_old.html
abfca4f 
I have deleted this file because it is causing performance issues and is not really getting used for anything
@mohitgedar
updated Style.css and index.js for like button
fbb990c 
I have updated these two files because for large game titles the like button was overflowing on the title , cause it hard to see , and cluttery
@mohitgedar
reduced size of second curson
8a42ac6 
I have reduced the size of second cursor because for many places it was covering the content , for example in case of like button
@mohitgedar
Updated contributors guideline
a9c84d9 
Further updated contributors guidline with better markup and more details.
@kunjgit
Copy link
Owner

kunjgit commented Jul 25, 2024

Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43
Copy link
Collaborator

Resolve merge conflicts of gamesdata. json

@mohitgedar
Copy link
Contributor Author

@ishita-43 conflicts are resloved

ishita-43
ishita-43 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 27, 2024
@kunjgit kunjgit merged commit 9e88087 into kunjgit:main Jul 28, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 28, 2024

Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
3 participants
@mohitgedar @kunjgit @ishita-43