Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game Added #4928

Closed
wants to merge 0 commits into from
Closed

Game Added #4928

wants to merge 0 commits into from

Conversation

parthshah02
Copy link
Contributor

@parthshah02 parthshah02 commented Jul 22, 2024 •
edited
Loading

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 22, 2024

Thank you @Parth20GitHub ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@parthshah02
Copy link
Contributor Author

FIXED #4927

ishita-43
ishita-43 requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make following changes
add your game entry into the main readdme.md file of the gamezone repo
add your game image in the asset folder of the gamezone

@kunjgit kunjgit mentioned this pull request Jul 23, 2024
Closed
10 tasks
parthshah02

This comment was marked as resolved.

Sign in to view

@parthshah02
Copy link
Contributor Author

Please check

@parthshah02 parthshah02 requested a review from ishita-43 July 23, 2024 14:19
@ishita-43
Copy link
Collaborator

Resolve merge conflicts or resync the file with the latest changes and then only add one line entry of your game in the file

@parthshah02
Copy link
Contributor Author

parthshah02 commented Jul 24, 2024 via email

@kunjgit
Copy link
Owner

kunjgit commented Jul 24, 2024

Thank you @Parth20GitHub , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@parthshah02 parthshah02 deleted the schulte branch July 24, 2024 15:01
@parthshah02 parthshah02 restored the schulte branch July 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 Awaiting requested review from ishita-43

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthshah02 @kunjgit @ishita-43