Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fead/add snake gun water game #4840

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

ANKeshri
Copy link
Contributor

PR Description 📜

In this game winner will get 1 point. if both choose the same then both will get 1 points. in total of 10 rounds who gets the highest points will be considered as winner . Please see the video attached . Its ui is lookig good .

Fixes #4820


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Recording.2024-07-12.230816.mp4


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 12, 2024

Thank you @ANKeshri ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ANKeshri
Copy link
Contributor Author

@kunjgit please review and merge my pr

@ANKeshri
Copy link
Contributor Author

/assign

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your pr and make following changes

README.md Show resolved Hide resolved
assets/images/image.png Outdated Show resolved Hide resolved
@ANKeshri
Copy link
Contributor Author

ANKeshri commented Jul 17, 2024

Please update your pr and make following changes

done the requested changes @ishita-43 please review it

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 17, 2024
@kunjgit kunjgit merged commit 17e0aae into kunjgit:main Jul 18, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 18, 2024

Thank you @ANKeshri , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Add new game Snake Water gun
3 participants