Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Uno game with computer #4764

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Added Uno game with computer #4764

merged 6 commits into from
Jul 14, 2024

Conversation

debangi29
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4657


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image

Recording.2024-06-22.103858.mp4


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 7, 2024

Thank you @debangi29 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@debangi29
Copy link
Contributor Author

Please review this PR @kunjgit

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pLease make sure following are included in your pr 🔢
Main Readme.md file with your game entry in there (follow format)
Repo's Asset folder with image of game(following naming convention)

@debangi29
Copy link
Contributor Author

I have made the required Changes @ishita-43
Please check this PR
Thanks :)

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will find asset folder in gamezone repo there you need to add the game image other images of games already present there

@debangi29
Copy link
Contributor Author

@ishita-43 I have done it :)

Thank Youuu :))
Please check the PR

@debangi29
Copy link
Contributor Author

Please check it @ishita-43
Thanks

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 14, 2024
@kunjgit kunjgit merged commit 3f15adf into kunjgit:main Jul 14, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 14, 2024

Thank you @debangi29 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Add UNO game with computer
3 participants