fixed the bugs of Main website #4761
Conversation
these 4 images should have been in assets/images but were placed in assets/ folder so i moved them to their right destination
I have added images for the games that had not provided preview images , by taking screenshots of the game
I have modified the index.html file which has cleared most of bugs such as scroller not working , contributors pagination not working , removed duplicate Socials and also made the website page vertical , removed unnecessary links and empty title.
I have updated this file to remove the CSS related to the elements that I removed in html file
I have updated gameData.json because there were some syntax error, because of which the games were not loading on the website , also removed some duplicated entries of the game and also arranged it well so that new games can be added in the end easily, also updated image links as they were not working or loading preview images properly.
some games did not have preview images added so I added them , some had wrong names so modified them
This game had index.html file named as index.file , so I updated the extension of the file so that the game works properly
I have updated the gameData.json again as some of the corrections were left by oversight and also added preview of a game that was not present
|
Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗 |
|
Hi, resolve the conflicts of gamesData.json making sure no data is lost and your changes also preserved in there |
|
hey , I did not remove any of the games that were there before I updated gameData.json to remove duplicate entries , and arrange them in order as some games had numbers upto 500 ,so I moved them to different keys so that when we add games in future we can just add them in the last of file. I have not added the games that are not present in the list yet . I will add them in another PR , the main purpose of this PR is to modify least and make the website working again. If you check the last lines of the files before change you will find duplicate entries ,some with same key , eg: line 2133 onwards and 2004 onwards |
these are the positions where the games have been moves which are creating a conflict At present the gameData.json file is syntax wise incorrect and generate errors so trying to resolve conflicts with this file is not possible , we have to update the file alltogether , and as of your concern that if old games were removed , I can assure you that they were not . only duplicates were removed and correct images urls were provided and those games that didn't had images , images were added for them |
mohitgedar
force-pushed
the
main
branch
2 times, most recently
from
40dfb80 to
f1fe62e
Compare
|
Hey I had to force-push because there was some trouble with the commit 124fb75 , it had different changes for local repo and this PR |
|
conflict resolved by 194ee65 |
with recent changes of 8/7/24 Games were not loading, my previous bug fix was not working anymore because gameData.json was not correctly refered to with new update of main project but after new changes it works
okay i am approving the pr , continue with your next issue |
ishita-43
added
level1
|
Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗. |
PR Description 📜
I have removed the bugs of the main website , such as
Fixes #4760
Mark the task you have completed ✅
Add your screenshots(Optional) 📸
Adding link to preview video as size was large and git don't allow more than 10mb
https://youtu.be/3efY6Wn_y40
Thank you soo much for contributing to our repository 💗