Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Game:-Dice_Rolling_simulator #4759

Merged
merged 15 commits into from
Jul 9, 2024
Merged

New Game:-Dice_Rolling_simulator #4759

merged 15 commits into from
Jul 9, 2024

Conversation

priyashuu
Copy link
Contributor

PR Description 📜

**** Description
The dice rolling simulator is a simple application built using Python and the Tkinter library for the graphical user interface (GUI). The simulator mimics the action of rolling a dice, providing a random outcome between 1 and 6 each time the user interacts with the interface. This application is useful for games, educational purposes, or simply for fun.

Game Logic

Initialization: When the program starts, it initializes the main window using Tkinter.
Dice Roll: A function generates a random number between 1 and 6 using Python's random module.
Display: The result of the dice roll is displayed on the GUI, typically as a number or a graphical representation of a dice face.
Interaction: The user can roll the dice by clicking a button on the GUI, which triggers the dice roll function.
Fixes # <4754>


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

video_of_dice_rolling.mp4

Screenshot 2024-07-07 161502



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 7, 2024

Thank you @priyashuu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi please do the following changes:-
add your game entry in readme.md file of the repo this will make changes made by you visible in the live project
and also add a image of your game in asset folder of the repo follow naming convention while naming the image mentioned in contribution guidelines

@priyashuu
Copy link
Contributor Author

priyashuu commented Jul 8, 2024

Hi @ishita-43 ,
I wanted to inform you that I accidentally added one more branch during my last commit, which seems to have caused a conflict with the current pull request.

Could you please review the updated pull request and let me know if any further actions are required from my side?

README.md Outdated
@@ -844,6 +844,12 @@ This repository also provides one such platforms where contributers come over an
| [IKnowYou-Mind-Reading-Game](https://github.com/kunjgit/GameZone/tree/main/Games/IKnowYou-Mind-Reading-Game) |
| [Tic_Tac_Toe_Neon](https://github.com/kunjgit/GameZone/tree/main/Games/Tic_Tac_Toe_Neon) | [Magic_8_ball_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Magic_8_ball) |
| [Catch_Craze](https://github.com/kunjgit/GameZone/tree/main/Games/Catch_Craze) |
<<<<<<< HEAD
| [Dice_Rolling_Simulator](https://github.com/priyashuu/GameZone/tree/main/Games/Dice_rolling_simulator)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the duplicate entry

README.md Outdated
@@ -844,6 +844,12 @@ This repository also provides one such platforms where contributers come over an
| [IKnowYou-Mind-Reading-Game](https://github.com/kunjgit/GameZone/tree/main/Games/IKnowYou-Mind-Reading-Game) |
| [Tic_Tac_Toe_Neon](https://github.com/kunjgit/GameZone/tree/main/Games/Tic_Tac_Toe_Neon) | [Magic_8_ball_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Magic_8_ball) |
| [Catch_Craze](https://github.com/kunjgit/GameZone/tree/main/Games/Catch_Craze) |
<<<<<<< HEAD
| [Dice_Rolling_Simulator](https://github.com/priyashuu/GameZone/tree/main/Games/Dice_rolling_simulator)
=======
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

README.md Outdated
=======
|[Dice_Rolling_Simulator](https://github.com/priyashuu/GameZone/tree/priyashuu-patch-1/Games/Dice_rolling_simulator)

>>>>>>> priyashuu-patch-1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line also
everything else is good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done , i removed these lines

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 9, 2024
@kunjgit kunjgit merged commit c77066f into kunjgit:main Jul 9, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 9, 2024

Thank you @priyashuu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@priyashuu
Copy link
Contributor Author

Thank you so much for your kind words❤️ .
I just want to ask why my game level points got reduced, I just want to ask for improvement in future..
See you soon with a next PR🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants