Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultimate_Football_Manager #4662

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Ultimate_Football_Manager #4662

merged 10 commits into from
Jul 8, 2024

Conversation

atul2727
Copy link
Contributor

PR Description 📜

Added Ultimate Football Manager game.
Fixes #4612

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Ultimate Football Manager

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 22, 2024

Thank you @atul2727 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@atul2727
Copy link
Contributor Author

@ishita-43 may you please check my pr

ishita-43
ishita-43 requested changes Jun 24, 2024
View reviewed changes
Games/.DS_Store Outdated Show resolved Hide resolved
assets/js/index.js Show resolved Hide resolved
@atul2727
Copy link
Contributor Author

Resolved the requested changes and solved the conflict. Please review @ishita-43

ishita-43
ishita-43 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD TO GO!!

@atul2727
Copy link
Contributor Author

atul2727 commented Jul 5, 2024

@ishita-43 please add the gssoc labels

ishita-43
ishita-43 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 7, 2024
@kunjgit kunjgit merged commit 9f21097 into kunjgit:main Jul 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 8, 2024

Thank you @atul2727 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Ultimate Football Manager
3 participants
@atul2727 @kunjgit @ishita-43