Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: All games recovered and 3D box game URL fixed #4507

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

anisharma07
Copy link
Contributor

@anisharma07 anisharma07 commented Jun 13, 2024

PR Description 📜

I fixed the games not showing up issue on the live gamezone website and also fixed url not found for 3d box game...

Fixes #4191


Tasks completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • My changes generates no new warnings.
  • I have added screenshot for website preview in assets/images
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

fixed every line of game.json ... numbering was incorrect ... so i corrected it manually and there were some syntax error too...
image


2024-06-14_02-27-18.mp4

In index.js i corrected the no. of games from 418 to 417 the figure i got from finding length of game.json
image

all rest changes in index.js and script.js are due to my code formatter... you can ignore them they were only indentation changes... you can also check if there is any difference using difference checker website...


please mark the gssoc labels ## Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 13, 2024

Thank you @anisharma07 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@anisharma07
Copy link
Contributor Author

@kunjgit The games are not displaying on the live website ... this PR fixes the issue .... would be great if you merge it

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level1 Documentation and small bug fixes in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 16, 2024
@kunjgit kunjgit merged commit 472c939 into kunjgit:main Jun 16, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 16, 2024

Thank you @anisharma07 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@anisharma07 anisharma07 deleted the feature-branch branch June 17, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: 3D box game not available
3 participants