Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new game Whack a mole #4477

Merged
merged 10 commits into from
Jun 21, 2024
Merged

added new game Whack a mole #4477

merged 10 commits into from
Jun 21, 2024

Conversation

1911aditi
Copy link
Contributor

PR Description 📜

i have added a new game whack a mole.
pls assign me under GSSOC'24.
Fixes #4475

##4475

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

whack a mole


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 12, 2024

Thank you @1911aditi ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@1911aditi
Copy link
Contributor Author

I have resolved the issue
Can u check now?

@1911aditi
Copy link
Contributor Author

Can u check now?

ishita-43
ishita-43 requested changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the desired changes!!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@1911aditi
Copy link
Contributor Author

check now

ishita-43
ishita-43 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

@1911aditi resolve merge conflicts

@1911aditi
Copy link
Contributor Author

check now

@kunjgit kunjgit merged commit 590c313 into kunjgit:main Jun 21, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 21, 2024

Thank you @1911aditi , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit mentioned this pull request Jul 15, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Whack-a-Mole
3 participants
@1911aditi @kunjgit @ishita-43