Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4422

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Update README.md #4422

merged 3 commits into from
Jun 15, 2024

Conversation

GUNJESH843
Copy link
Contributor

PR Description 📜

This PR fixes broken links in the README.md file.

Fixes #4421

  • Fixed the broken links for Laser Darts and Emoji Slot Machine.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE

Add your screenshots(Optional) 📸

Before:
Screenshot 2024-06-10 214320

After:
Screenshot 2024-06-10 215652



Thank you so much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 10, 2024

Thank you @GUNJESH843 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@GUNJESH843
Copy link
Contributor Author

GUNJESH843 commented Jun 10, 2024

hey, @ishita-43, this PR is a follow-up to your comment(#4253 (comment)) on my previous PR,

Just had a small request, if you could label my PR as level2.

I would also love to work any other Technical or nontechnical issues.

Thank you.

@ishita-43
Copy link
Collaborator

if you would add other changes in this pr we will add level otherwise this would remain level 1
let me know you are gonna update this pr.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level1 Documentation and small bug fixes in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 12, 2024
@GUNJESH843
Copy link
Contributor Author

if you would add other changes in this pr we will add level otherwise this would remain level 1
let me know you are gonna update this pr.

Could you clarify what other changes?

@kunjgit
Copy link
Owner

kunjgit commented Jun 13, 2024

@GUNJESH843 resolve merge conflicts !

@GUNJESH843
Copy link
Contributor Author

@kunjgit
hey,

I have resolved the merge conflicts.

@ishita-43
Copy link
Collaborator

if you would add other changes in this pr we will add level otherwise this would remain level 1
let me know you are gonna update this pr.

Could you clarify what other changes?

depends on you!

@kunjgit
Copy link
Owner

kunjgit commented Jun 15, 2024

@GUNJESH843 resolve merge conflicts with latest changes after review is done then make sure there is no conflicts !

@GUNJESH843
Copy link
Contributor Author

@kunjgit please review the PR the conflict is resolved.

@kunjgit kunjgit merged commit 89e51a5 into kunjgit:main Jun 15, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 15, 2024

Thank you @GUNJESH843 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation Bug]: Broken Links in README.md
3 participants