-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new game - Go fish #4417
Added new game - Go fish #4417
Conversation
Thank you @tanyagupta01 ,for creating the PR and contributing to our GameZone π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADD screenshot of your game in assest folder of gamezone
update the readme.md file of the gamezone and enter your game there refer other entries for format
@ishita-43 I have made the changes that you asked for. Kindly check them and please also assign level to this PR. |
@ishita-43 @kunjgit kindly review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add your game entry as other people have added
@ishita-43 Done. Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!!
@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it. |
@tanyagupta01 resolve merge conflicts |
@kunjgit Done. Kindly review and merge. |
We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo |
Oh okay. Thanks . Please merge if everything else is fine. |
Will soon be merged by the Admin. |
Thank you @tanyagupta01 , for your valuable time and contribution in our GameZone π. |
PR Description π
This PR adds the card game Go-fish.
Fixes #4411
Mark the task you have completed β
Add your screenshots(Optional) πΈ
![Uploading Screenshot 2024-06-10 at 7.52.29β―PM.pngβ¦]()