Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new game - Go fish #4417

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Added new game - Go fish #4417

merged 7 commits into from
Jun 20, 2024

Conversation

tanyagupta01
Copy link
Contributor

PR Description πŸ“œ

This PR adds the card game Go-fish.
Fixes #4411

Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ

Screenshot 2024-06-10 at 7 51 57β€―PM Screenshot 2024-06-10 at 7 52 08β€―PM ![Uploading Screenshot 2024-06-10 at 7.52.29β€―PM.png…]() Screenshot 2024-06-10 at 7 52 54β€―PM Screenshot 2024-06-10 at 7 53 19β€―PM

@kunjgit
Copy link
Owner

kunjgit commented Jun 10, 2024

Thank you @tanyagupta01 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD screenshot of your game in assest folder of gamezone
update the readme.md file of the gamezone and enter your game there refer other entries for format

@tanyagupta01
Copy link
Contributor Author

@ishita-43 I have made the changes that you asked for. Kindly check them and please also assign level to this PR.

@tanyagupta01 tanyagupta01 requested a review from ishita-43 June 12, 2024 17:15
@tanyagupta01
Copy link
Contributor Author

@ishita-43 @kunjgit kindly review this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add your game entry as other people have added

@tanyagupta01
Copy link
Contributor Author

@ishita-43 Done. Kindly review.

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge πŸ₯³ gssoc GSSoC24 program label labels Jun 19, 2024
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@tanyagupta01
Copy link
Contributor Author

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

@tanyagupta01 resolve merge conflicts

@tanyagupta01
Copy link
Contributor Author

@kunjgit Done. Kindly review and merge.

@ishita-43
Copy link
Collaborator

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

@tanyagupta01
Copy link
Contributor Author

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

Oh okay. Thanks . Please merge if everything else is fine.

@ishita-43
Copy link
Collaborator

@ishita-43 if you find it suitable, kindly give me a higher level on this PR as you have given to the other games according to the complexity and individuality of it.

We appreciate your hard work but Lots of card games are already present in the repo thats why we placed this as an enhancement of the repo

Oh okay. Thanks . Please merge if everything else is fine.

Will soon be merged by the Admin.

@kunjgit kunjgit merged commit 0e46659 into kunjgit:main Jun 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

Thank you @tanyagupta01 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge πŸ₯³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: go fish - master
3 participants